Fixed reindexing arith with duplicates #35303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jbrockmendel. |
TomAugspurger
added
the
Numeric Operations
jreback
added
the
Indexing
|
Having trouble with ASV right now. Things seem OK in this small benchmark though In [15]: df1 = pd.DataFrame(np.random.randn(1000, 500))
In [16]: df2 = pd.DataFrame(np.random.randn(1000, 501))
In [17]: %timeit df1 + df2
# master
3.8 ms ± 115 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
# PR
3.77 ms ± 104 µs per loop (mean ± std. dev. of 7 runs, 100 loops each) |
| # https://github.com/pandas-dev/pandas/issues/35194 | ||
| indexer, _ = result.columns.get_indexer_non_unique(join_columns) | ||
| indexer = algorithms.unique1d(indexer) | ||
| result = result._reindex_with_indexers( |
There was a problem hiding this comment.
is there a public method that could be used here?
There was a problem hiding this comment.
Not that I know of.
There was a problem hiding this comment.
we do this type of thing in indexing.py, so should try to refactor later
|
LGTM |
|
thanks @TomAugspurger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35194
Still need to run ASV on this. This was a regression from 0.25.x to 1.0. It doesn't have to go in 1.1, but probably better for 1.1.0.rc0 than a 1.1.1 release.