Skip to content

ENH: add percentage threshold to dropna #35300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pandas/core/frame.py
Original file line number Diff line number Diff line change
Expand Up @@ -4874,7 +4874,9 @@ def notna(self) -> "DataFrame":
def notnull(self) -> "DataFrame":
return ~self.isna()

def dropna(self, axis=0, how="any", thresh=None, subset=None, inplace=False):
def dropna(
self, axis=0, how="any", thresh=None, perc=None, subset=None, inplace=False
):
"""
Remove missing values.

Expand Down Expand Up @@ -4904,6 +4906,9 @@ def dropna(self, axis=0, how="any", thresh=None, subset=None, inplace=False):

thresh : int, optional
Require that many non-NA values.
perc : float, optional
If a column or row exceeds this percentage threshold of
NA-values, it will be dropped.
subset : array-like, optional
Labels along other axis to consider, e.g. if you are dropping rows
these would be a list of columns to include.
Expand Down Expand Up @@ -4998,6 +5003,11 @@ def dropna(self, axis=0, how="any", thresh=None, subset=None, inplace=False):

if thresh is not None:
mask = count >= thresh
elif perc is not None:
if axis == 0:
mask = agg_obj.isna().mean(axis=agg_axis) <= perc
else:
mask = agg_obj.isna().mean() <= perc
elif how == "any":
mask = count == len(agg_obj._get_axis(agg_axis))
elif how == "all":
Expand Down
24 changes: 24 additions & 0 deletions pandas/tests/extension/base/missing.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,27 @@ def test_use_inf_as_na_no_effect(self, data_missing):
with pd.option_context("mode.use_inf_as_na", True):
result = ser.isna()
self.assert_series_equal(result, expected)


def test_dropna_perc():
# GH 35299
df = pd.DataFrame(
{
"col": ["A", "A", "B", "B"],
"A": [80, np.nan, np.nan, np.nan],
"B": [80, np.nan, 76, 67],
}
)

# axis = 1
expected = pd.DataFrame({"col": ["A", "A", "B", "B"], "B": [80, np.nan, 76, 67]})
result = df.dropna(perc=0.5, axis=1)
tm.assert_frame_equal(result, expected)

# axis = 0
expected = pd.DataFrame(
{"col": ["A", "B", "B"], "A": [80.0, np.nan, np.nan], "B": [80.0, 76.0, 67.0]}
)
expected.index = [0, 2, 3]
result = df.dropna(perc=0.5)
tm.assert_frame_equal(result, expected)