Fix indexing, reindex on all-sparse SparseArray. #35287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
added
the
Regression
|
Looks like #34908 built on the buggy functionality. I may need to revert it as well. |
TomAugspurger
commented
Jul 15, 2020
Comment on lines
-44
to
-47
| @pytest.fixture(params=[0, np.nan]) | ||
| def data_zeros(request): | ||
| return SparseArray(np.zeros(100, dtype=int), fill_value=request.param) | ||
|
|
There was a problem hiding this comment.
I don't think this was doing anything on master.
TomAugspurger
commented
Jul 15, 2020
| @@ -399,31 +399,3 @@ def test_item(self, data): | |||
|
|
|||
| with pytest.raises(ValueError, match=msg): | |||
| s.item() | |||
|
|
|||
| def test_boolean_mask_frame_fill_value(self, data): | |||
There was a problem hiding this comment.
I noticed that these tests were passing regardless of the change, so I'm not sure they were testing what we expected. I've left them removed.
TomAugspurger
changed the title
jreback
approved these changes
Jul 15, 2020
|
Thanks, I think we're good here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35286.
Also added a regression tests for the issue reported there.