REF: de-duplicate vectorized normalize functions #35250
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #35245.
I think we lose some ground on UTC/naive because a
with nogil
is removed here. Im OK with this tradeoff since it moves us towards being able to de-duplicate a bunch of code in this file; im hopeful we can eventually get the nogil back (in fact, i think we may be able to get it back for everything but the tzlocal case, and maybe even that pending cython/cython#3733)