-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TST: GH20676 Verify equals operator for list of Numpy arrays #35237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
|
||
@pytest.mark.parametrize( | ||
"input_data", [[np.array([1, 2]), np.array([1, 2])]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can in-line this data in the test since is parameterizing over 1 value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @avinashpancham lgtm. as a follow-up test_equals in pandas\tests\generic\test_generic.py could be split and the Series tests moved here.
…ies/methods/test_equals.py
@simonjayhawkins Moved the Series.equals tests from Code Sample, a copy-pastable example if possible arr = np.array([1, 2])
s1 = pd.Series([arr, arr])
s2 = s1.copy()
s1[1] = 9
s1.equals(s2) Problem description
Expected Output Output of pd.show_versions()
|
@avinashpancham can you file a new issue about this on master. thanks. |
thanks @avinashpancham |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff