TYPING/DOC: Move custom type to _typing and add whatsnew #35220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesdong1991
commented
Jul 10, 2020
| @@ -332,6 +332,7 @@ Other enhancements | |||
| - :meth:`~Series.explode` now accepts ``ignore_index`` to reset the index, similarly to :meth:`pd.concat` or :meth:`DataFrame.sort_values` (:issue:`34932`). | |||
| - :meth:`read_csv` now accepts string values like "0", "0.0", "1", "1.0" as convertible to the nullable boolean dtype (:issue:`34859`) | |||
| - :class:`pandas.core.window.ExponentialMovingWindow` now supports a ``times`` argument that allows ``mean`` to be calculated with observations spaced by the timestamps in ``times`` (:issue:`34839`) | |||
| - :meth:`DataFrame.agg` and :meth:`Series.agg` now accept named aggregation for renaming the output columns/indexes. (:issue:`26513`) | |||
There was a problem hiding this comment.
Apologize that somehow i didn't notice there wasn't a whatsnew note.
Added here!
WillAyd
reviewed
Jul 10, 2020
| @@ -96,3 +96,11 @@ | |||
| # DataFrame::sort_index, among others | |||
| ValueKeyFunc = Optional[Callable[["Series"], Union["Series", AnyArrayLike]]] | |||
| IndexKeyFunc = Optional[Callable[["Index"], Union["Index", AnyArrayLike]]] | |||
|
|
|||
| # types of `func` kwarg for DataFrame.aggregate and Series.aggregate | |||
| AggFuncTypeBase = Union[Callable, str] | |||
There was a problem hiding this comment.
If there is a more generic name you can think of than AggFuncTypeBase I think would be useful in other areas that aren't aggregations; i.e. in groupby a lot we accept a callable / str and resolve the latter to a builtin or NumPy func if we can, which could use this same type
WillAyd
approved these changes
Jul 10, 2020
|
thanks @charlesdong1991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup of #29116
details see : #29116 (comment)