Skip to content

TST add corner cases in test_constructors #35216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 11, 2020
Merged

TST add corner cases in test_constructors #35216

Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5c0a095
TST add test case to drop_duplicates for inplace=True
r-toroxel Jul 3, 2020
b004e05
Merge remote-tracking branch 'upstream/master'
r-toroxel Jul 4, 2020
6b940bb
CLN PEP-8
r-toroxel Jul 4, 2020
4b8679c
TST move to existing test
r-toroxel Jul 7, 2020
cb2ab5e
CLN remove parenthesis
r-toroxel Jul 7, 2020
8fee1b7
Merge remote-tracking branch 'upstream/master'
r-toroxel Jul 8, 2020
8c68a0a
Merge remote-tracking branch 'upstream/master'
r-toroxel Jul 9, 2020
2369141
TST test from_tuple corner cases
r-toroxel Jul 9, 2020
824b5f4
Merge remote-tracking branch 'upstream/master' into TST-more=corner-c…
r-toroxel Jul 10, 2020
04a86a7
add comment
r-toroxel Jul 10, 2020
c1cf452
CLN run black formatting
r-toroxel Jul 11, 2020
40faa87
CLN refactor case as separate test
r-toroxel Jul 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions pandas/tests/frame/test_constructors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1168,6 +1168,12 @@ def test_constructor_list_of_odicts(self):
OrderedDict([["b", 3], ["c", 4], ["d", 6]]),
]

# single row dataframe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create this as a separate test?

result = DataFrame([data[0]])
expected = DataFrame.from_dict(
dict(zip([0], [data[0]])), orient="index")
tm.assert_frame_equal(result, expected.reindex(result.index))

result = DataFrame(data)
expected = DataFrame.from_dict(
dict(zip(range(len(data)), data)), orient="index"
Expand Down Expand Up @@ -1493,16 +1499,17 @@ def test_from_dict_columns_parameter(self):
)

@pytest.mark.parametrize(
"data_dict, keys",
"data_dict, keys, orient",
[
([{("a",): 1}, {("a",): 2}], [("a",)]),
([OrderedDict([(("a",), 1), (("b",), 2)])], [("a",), ("b",)]),
([{("a", "b"): 1}], [("a", "b")]),
({}, [], "index"),
([{("a",): 1}, {("a",): 2}], [("a",)], "columns"),
([OrderedDict([(("a",), 1), (("b",), 2)])], [("a",), ("b",)], "columns"),
([{("a", "b"): 1}], [("a", "b")], "columns"),
],
)
def test_constructor_from_dict_tuples(self, data_dict, keys):
def test_constructor_from_dict_tuples(self, data_dict, keys, orient):
# GH 16769
df = DataFrame.from_dict(data_dict)
df = DataFrame.from_dict(data_dict, orient)

result = df.columns
expected = Index(keys, dtype="object", tupleize_cols=False)
Expand Down