Parse raised exceptions and their error messages sans interpolation/format spec #3519
Conversation
|
This could probably use a |
|
@jreback this could be merged if y'all think it's useful...all the nan's in the above pic are gone now since i filled all those missing or vague assert messages in and a few others as well. rls notes here? |
|
I didnt' realize you changed a bunch of no-message AssertionErrors.....so this is good... does this pass travis? |
i was hoping that the script would be useful (alas, i probably spent too much time creating the assertion-table-lister thing because i think asts are fun) it should pass...it wasn't before because i did 1e9 rebases in a row and travis doen't like that |
|
@cpcloud |
|
this passes |
parse asserts script initial commit Signed-off-by: Phillip Cloud <[email protected]> CLN: start adding messages to empty assertions Signed-off-by: Phillip Cloud <[email protected]> ENH: new script to find raised exceptions that lack an error message You can also look at the current error messages for every raised exception
ghost
mentioned this pull request
This PR partially addresses #3024. It also provides a shiny new script useful looking at the current state of the messages in raised exceptions. Here's an example of some output:
Example
You can reproduce this with
from the top level pandas directory.
Description
The above line searches for all empty raises in the module
pandaswhose constructor matches the regular expression'.*assert.*'--not case sensitive.Note: This assumes you have installed pandas with
python setup.py develop. This will not work without that (well, that's not strictly true, but it will search for pandas code that's installed wherever you installed it/usr/*/site-packages/*/pandasor$VIRTUAL_ENV/*/pandas, for example, which is probably not what you want).To see all of the options and a short description you can do the usual: