Skip to content

CI: MacPython failing TestPandasContainer.test_to_json_large_numbers #35184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 62 commits into from
Jul 15, 2020
Merged

CI: MacPython failing TestPandasContainer.test_to_json_large_numbers #35184

merged 62 commits into from
Jul 15, 2020

Conversation

arw2019
Copy link
Member

@arw2019 arw2019 commented Jul 8, 2020

arw2019 added 30 commits June 27, 2020 05:24
@arw2019
add values.dtype.kind==f branch to array_with_unit_datetime
30c9b83
@arw2019
remove unnecessary styling changes
cf67f90
@arw2019
added cast_from_unit definition for float
a69b28c
@arw2019
to_datetime: added astyping for floats
9df9d4d
@arw2019
revert changes
5746581
@arw2019
revert changes
6b9d4de
@arw2019
revert styling change
0e3a876
@arw2019
_libs/tslib.pyx added comments
f1ae8f5
@arw2019
merge with master
2f25460
@arw2019
revert pandas/_libs/tslib.pyx
572363a
@arw2019
merge with master
a50b4fd
@arw2019
merge with master
b891030
@arw2019
merge with master
ecd8ce3
@arw2019
update Grouping.indicies to return for nan values
38bac1a
@arw2019
updated _GroupBy._get_index to return for nan values
65a2963
@arw2019
revert accidental changes
7df44d1
@arw2019
revert accidental changes
4eb8a17
@arw2019
revert accidental changes
21bb8e7
@arw2019
styling change
0daca66
@arw2019
merge with master
ee55191
@arw2019
added tests
0c0e289
@arw2019
fixed groupby/groupby.py's _get_indicies
a804909
@arw2019
removed debug statement
5e4419e
@arw2019
fixed naming error in test
1e694c9
@arw2019
remove type coercion block
d5e1a3b
@arw2019
added missing values handing for _GroupBy.get_group method
91947c5
@arw2019
updated indicies for case dropna=True
ce80f7c
@arw2019
cleaned up syntax
5c992d2
@arw2019
cleaned up syntax
15215fe
@arw2019
removed print statements
30c2fb5
@jreback
Copy link
Contributor

jreback commented Jul 9, 2020

can you make this a separate test and just xfail them?

@jreback jreback added the IO JSON read_json, to_json, json_normalize label Jul 9, 2020
@pep8speaks
Copy link

pep8speaks commented Jul 11, 2020 •
edited
Loading

Hello @arw2019! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-07-15 01:42:21 UTC

@arw2019 arw2019 changed the title CI: MacPython failing TestPandasContainer.test_to_json_large_numbers WIP CI: MacPython failing TestPandasContainer.test_to_json_large_numbers Jul 11, 2020
@TomAugspurger TomAugspurger added this to the 1.1 milestone Jul 14, 2020
@TomAugspurger
Copy link
Contributor

Pushed a commit xfailing the test for 32-bit. Opened #35279 to track it.

@TomAugspurger
Copy link
Contributor

My commit broke the other case. Will get it fixed up here soon.

@TomAugspurger
Copy link
Contributor

OK, just skipping that test on 32-bit systems, under the assumption that it's supposed to return an int64 dtype when sys.maxsize - 1 fits in an int64. Leaving updating the test to #35279.

@TomAugspurger
Copy link
Contributor

Merging to get CI passing at MacPython. Thanks @arw2019.

@TomAugspurger TomAugspurger merged commit 492e3e9 into pandas-dev:master Jul 15, 2020
@arw2019 arw2019 changed the title WIP CI: MacPython failing TestPandasContainer.test_to_json_large_numbers CI: MacPython failing TestPandasContainer.test_to_json_large_numbers Jul 15, 2020
@arw2019 arw2019 deleted the CI-MacPython-fails-to_json-large_nums branch July 16, 2020 18:55
fangchenli pushed a commit to fangchenli/pandas that referenced this pull request Jul 16, 2020
@arw2019 @fangchenli
WIP CI: MacPython failing TestPandasContainer.test_to_json_large_numb…
97d8bf1 
…ers (pandas-dev#35184)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

Assignees
No one assigned
Labels
IO JSON read_json, to_json, json_normalize Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

CI: MacPython failing TestPandasContainer.test_to_json_large_numbers
5 participants
@arw2019 @WillAyd @jreback @pep8speaks @TomAugspurger