REF: collect get_dst_info-using functions in tslibs.vectorized #35168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jul 8, 2020
| @@ -21,7 +21,10 @@ | |||
| import numpy as np | |||
| import pytz | |||
|
|
|||
| from pandas._libs.tslib import ints_to_pydatetime | |||
| try: | |||
There was a problem hiding this comment.
i think generally we should add a comment on what version these are changed so when we know when to remove the try/except
There was a problem hiding this comment.
isnt the idea to be able to run these benchmarks on older pandas versions basically indefinitely?
There was a problem hiding this comment.
sure, the reason I think we should add the version number is that so we can eventually remove these try/excepts, otherwise they will stay forever which is pretty cluttering. anyhow for another issue.
jreback
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm open to better names for the new module.
With these all in the same place, we can separate out helper functions and de-duplicate a whole bunch of verbose code.