Skip to content

Fixed Series.apply performance regression #35166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2020
Merged

Fixed Series.apply performance regression #35166

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcc44d5
Fixed Series.apply performance regression
TomAugspurger Jul 7, 2020
4a23d3f
Merge remote-tracking branch 'upstream/master' into 35047-perf
TomAugspurger Jul 8, 2020
8c41f09
copy in loop
TomAugspurger Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions pandas/core/apply.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,16 +291,14 @@ def apply_series_generator(self, partial_result=None) -> Tuple[ResType, "Index"]
res_index = res_index.take(successes)

else:
for i, v in series_gen_enumeration:

with option_context("mode.chained_assignment", None):
with option_context("mode.chained_assignment", None):
for i, v in series_gen_enumeration:
# ignore SettingWithCopy here in case the user mutates
results[i] = self.f(v)

if isinstance(results[i], ABCSeries):
# If we have a view on v, we need to make a copy because
# series_generator will swap out the underlying data
results[i] = results[i].copy(deep=False)
if isinstance(results[i], ABCSeries):
# If we have a view on v, we need to make a copy because
# series_generator will swap out the underlying data
results[i] = results[i].copy(deep=False)

return results, res_index

Expand Down