Skip to content

Fix regression on datetime in MultiIndex #35140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 8, 2020
Merged

Fix regression on datetime in MultiIndex #35140

merged 4 commits into from
Jul 8, 2020

Conversation

Dr-Irv
Copy link
Contributor

@Dr-Irv Dr-Irv commented Jul 6, 2020

@WillAyd
Copy link
Member

WillAyd commented Jul 6, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@Dr-Irv Dr-Irv mentioned this pull request Jul 6, 2020
Closed
3 tasks
@WillAyd
Copy link
Member

WillAyd commented Jul 6, 2020

@jbrockmendel this is what you had in mind right?

@jbrockmendel
Copy link
Member

Yes

@jreback jreback added the Indexing Related to indexing on series/frames, not to indexes themselves label Jul 6, 2020
@jreback jreback added this to the 1.1 milestone Jul 6, 2020
jreback
jreback requested changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a whatsnew, bug fixes 1.1 in conversion section, patch looks good, some comments

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Jul 7, 2020

can you add a whatsnew, bug fixes 1.1 in conversion section, patch looks good, some comments

@jreback I'm not going to add a whatsnew, as this was NOT a bug in 1.0.5, but was introduced during the development of 1.1 . I will do the other things.

@jreback
Copy link
Contributor

jreback commented Jul 8, 2020

can you add a whatsnew, bug fixes 1.1 in conversion section, patch looks good, some comments

@jreback I'm not going to add a whatsnew, as this was NOT a bug in 1.0.5, but was introduced during the development of 1.1 . I will do the other things.

thanks

@jreback jreback merged commit e9d90b4 into pandas-dev:master Jul 8, 2020
@Dr-Irv Dr-Irv deleted the issue35015 branch July 8, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

BUG: MultiIndex columns containing datetime cannot be used (regression from 1.0.5 to master)
5 participants
@Dr-Irv @WillAyd @jbrockmendel @jreback @TomAugspurger