Skip to content

TST: update gbq service account key #35090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jul 1, 2020

Re-enable gbq integration tests.

  • closes CI: gbq tests failing #34779
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@tswast tswast force-pushed the issue34779-enable-gbq-tests branch from 1939236 to 7954b7d Compare July 1, 2020 20:08
@tswast
Copy link
Contributor Author

tswast commented Jul 1, 2020

Build currently running in my personal Travis config at https://travis-ci.org/github/tswast/pandas/builds/704081779

I need additional permissions in order to create the encryption key environment variables on the pandas-dev Travis config.

@tswast tswast force-pushed the issue34779-enable-gbq-tests branch from 7954b7d to 45fbc7d Compare July 1, 2020 20:44
@jreback jreback added this to the 1.1 milestone Jul 2, 2020
@jreback
Copy link
Contributor

jreback commented Jul 2, 2020

@tswast does this run?

@tswast
Copy link
Contributor Author

tswast commented Jul 6, 2020

@jreback It runs on my fork, but still having trouble with encrypting the keys for use in the pandas-dev org.

$ travis encrypt-file -r pandas-dev/pandas $GBQ_JSON_FILE travis_gbq.json.enc -f

encrypting pandas-gbq-tests-e842e94bcd25.json for pandas-dev/pandas
storing result as travis_gbq.json.enc
storing secure env variables for decryption
resource not found ({"error":"Couldn't find repository"})

I can now see the pandas project under "my repositories" in Travis. But maybe it's still not working because I can't see the "Settings" menu like I can on my fork.

Screen Shot 2020-07-06 at 9 45 32 AM

Screen Shot 2020-07-06 at 9 47 25 AM

@tswast
Copy link
Contributor Author

tswast commented Jul 6, 2020

Looks like write access is needed in order to update settings (including adding encryption keys?). 😕 https://docs.travis-ci.com/user/travis-ci-for-private/#who-has-access-to-the-builds

Re-enable gbq integration tests.
@tswast tswast force-pushed the issue34779-enable-gbq-tests branch from d30bcb9 to 784f211 Compare July 7, 2020 15:02
@tswast tswast marked this pull request as ready for review July 7, 2020 15:03
@tswast
Copy link
Contributor Author

tswast commented Jul 7, 2020

I was able to add the required keys to Travis. Since Travis doesn't allow the use of keys from forks, I also pushed this branch https://github.com/pandas-dev/pandas/tree/issue34779-enable-gbq-tests, which can be deleted once verifying the build at https://travis-ci.org/github/pandas-dev/pandas/builds/705824144

@tswast tswast mentioned this pull request Jul 7, 2020
@jreback
Copy link
Contributor

jreback commented Jul 9, 2020

ok let's try this.

@jreback jreback merged commit c8b44dd into pandas-dev:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: gbq tests failing
2 participants