Skip to content

No fastcall attribute in POWER platform #35083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2020
Merged

No fastcall attribute in POWER platform #35083

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
020d53e
No fastcall attribute in POWER platform
ayappanec Jul 1, 2020
3886603
Remove fastcall attribute
ayappanec Jul 1, 2020
67cf537
Remove FASTCALL_ATTR macro
ayappanec Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pandas/_libs/src/ujson/lib/ultrajson.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,7 @@ typedef uint32_t JSUINT32;

#define FASTCALL_MSVC

#if !defined __x86_64__ && !defined __aarch64__
#define FASTCALL_ATTR __attribute__((fastcall))
#else
#define FASTCALL_ATTR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can remove this altogether would be preferable. No need for an empty define

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the empty defines also needs lot of cleanup in ultrajsondec.c . Otherwise there will be compilation problems. And also not sure about the fastcall defines under _WIN32 .

#endif

#define INLINE_PREFIX static inline

Expand Down