Skip to content

Fix issue #31708 Series.astype(str, skipna=True) vanished in the 1.0 release #35060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix issue #31708 Series.astype(str, skipna=True) vanished in the 1.0 release #35060

wants to merge 3 commits into from

Conversation

t0ma-sz
Copy link

@t0ma-sz t0ma-sz commented Jun 30, 2020

jreback
jreback requested changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure you understood the original issue
we are not adding this kwarg

@t0ma-sz
Copy link
Author

t0ma-sz commented Jun 30, 2020 •
edited
Loading

not sure you understood the original issue
we are not adding this kwarg

skipna is not passed as a kwarg, now it is valid keyword for astype
Right I'm not sure - would you delete this argument and have skipna=True in astype_nansafe? Then it would be API breaking change

@jreback
Copy link
Contributor

jreback commented Jul 2, 2020

@t0ma-sz i don't think its worth restoring this at all, rather fixing #25353 would be useful.

@gfyoung gfyoung added Bug Regression Functionality that used to work in a prior pandas version labels Jul 3, 2020
@jreback
Copy link
Contributor

jreback commented Jul 17, 2020

closing as wont fix - the underlying cause should be addressed rather than adding back unsupported api

@jreback jreback added this to the No action milestone Jul 17, 2020
@jreback jreback closed this Jul 17, 2020
@abekfenn abekfenn mentioned this pull request May 7, 2021
Open
@NumberPiOso NumberPiOso mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Bug Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Series.astype(str, skipna=True) vanished in the 1.0 release
3 participants
@t0ma-sz @jreback @gfyoung