-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fix Issue #34923: Inferred dtype at the end of df explode method #35011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @SanthoshBala18! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-07-20 11:26:43 UTC |
you may need to update the example in the docs / doc-string as well |
Pulling latest master branch
67138fe
to
5ad650d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pls merge master and ping on green
cf77d63
to
a9e08fc
Compare
@jreback, merged the master branch.. |
129b19a
to
f614451
Compare
I'm -1 on this. This is a breaking change and not a bug. the change for lists of ints with some rows containing empty lists now being cast to float should wait till a major release and maybe use the nullable integer type instead. current
this PR
|
closing this. see my comments on the issue (basically need to add an option |
df.explode()
ENH: #34923pandas/tests/frame/methods/test_explode.py, method test_inferred_dtype
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff