Skip to content

TST: df.loc[:, 'col'] returning a view, but df.loc[df.index, 'col'] returning a copy #34996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 9, 2020
Merged

TST: df.loc[:, 'col'] returning a view, but df.loc[df.index, 'col'] returning a copy #34996

Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b43f71c
TST: added test of view vs copy
arw2019 Jun 25, 2020
b9d3ef6
merge with master
arw2019 Jun 25, 2020
071f80a
TST: moved test closer to others related
arw2019 Jun 26, 2020
30c9b83
add values.dtype.kind==f branch to array_with_unit_datetime
arw2019 Jun 27, 2020
2f25460
merge with master
arw2019 Jun 29, 2020
572363a
revert pandas/_libs/tslib.pyx
arw2019 Jun 29, 2020
956e5f3
merge with master
arw2019 Jun 30, 2020
b891030
merge with master
arw2019 Jun 30, 2020
52aefc5
merge with master
arw2019 Jun 30, 2020
2850224
add test_loc_copy_vs_view to pandas/tests/indexing/test_loc.py
arw2019 Jun 30, 2020
5b9d498
resolve merge conflict
arw2019 Jun 30, 2020
d44b6ea
merge with upstream
arw2019 Jun 30, 2020
395e79c
added second test from GH15631
arw2019 Jun 30, 2020
21e9206
improved variable names
arw2019 Jun 30, 2020
90b29bb
merge with master
arw2019 Jul 2, 2020
654d25c
clarified test_in tests/indexing/test_loc.py
arw2019 Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pandas/tests/indexing/test_loc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,16 @@ def test_loc_index(self):
result = df.loc[pd.array(mask, dtype="boolean")]
tm.assert_frame_equal(result, expected)

def test_loc_copy_vs_view(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I am almost sure we have other tests about this, can you check and co-locate

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you're right. This one

pandas/pandas/tests/indexing/test_loc.py

Line 872 in f5b2e5a

def test_identity_slice_returns_new_object(self):

is very similar so moved it there

# GH 15631
x = DataFrame(zip(range(3), range(3)), columns=["a", "b"])

y = x.copy()
q = x.loc[:, "a"]
q += 2

tm.assert_frame_equal(x, y)

def test_loc_general(self):

df = DataFrame(
Expand Down