TYP: remove inappropriate use of cast #34990
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cast was silencing
error: Argument 2 to "zip" has incompatible type "Union[Sequence[Union[str, int]], Mapping[Optional[Hashable], Union[str, int]]]"; expected "Iterable[Union[str, int]]"
This error is because col_space is defined as
Union[str, int, Sequence[Union[str, int]], Mapping[Label, Union[str, int]]]
and theelif isinstance(col_space, dict):
would not catch non-dict mappings, which would go though the else.so the else is non-dict mappings and sequences and the cast to sequence is not safe.