Skip to content

REF: simplify _is_single_block/is_mixed_type #34935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 23, 2020
Merged

REF: simplify _is_single_block/is_mixed_type #34935

merged 6 commits into from
Jun 23, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

WillAyd
WillAyd reviewed Jun 23, 2020
View reviewed changes
pandas/core/internals/managers.py Outdated
0, len(self), 1
)
# Assumes we are 2D; overriden by SingleBlockManager
return len(self.blocks) <= 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason for this to be lte instead of eq? From the name I think the latter is more apt (and what it did previously?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, will update

WillAyd
WillAyd approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added the Clean label Jun 23, 2020
@jreback jreback added this to the 1.1 milestone Jun 23, 2020
@jreback jreback added the Internals Related to non-user accessible pandas implementation label Jun 23, 2020
@jreback jreback merged commit 3e8f14f into pandas-dev:master Jun 23, 2020
@jreback
Copy link
Contributor

jreback commented Jun 23, 2020

k thanks

@jbrockmendel jbrockmendel deleted the ref-is_mixed_dtype branch November 20, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @WillAyd