Skip to content

DOC: Fix language style #34924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

DOC: Fix language style #34924

merged 1 commit into from
Jun 23, 2020

Conversation

alimcmaster1
Copy link
Member

@wesm
Copy link
Member

wesm commented Jun 21, 2020

Thanks for doing this

@WillAyd
Copy link
Member

WillAyd commented Jun 21, 2020

Lgtm

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Jun 22, 2020
datapythonista
datapythonista approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alimcmaster1, lgtm. Is this ready to be merged? I see the WIP in the title.

@TomAugspurger
Copy link
Contributor

LGTM. These are all internal, so no need for a deprecation correct?

Thoughts on adding a linting rule to catch these in the future?

@alimcmaster1 alimcmaster1 changed the title WIP: Fix language style DOC: Fix language style Jun 22, 2020
@alimcmaster1
Copy link
Member Author

alimcmaster1 commented Jun 22, 2020 •
edited
Loading

LGTM. These are all internal, so no need for a deprecation correct?

Thoughts on adding a linting rule to catch these in the future?

Yep all internals. Good shout if ppl think a lint check is helpful here i'm happy to add.

P.S Any further thoughts/further ideas in this area welcomed.

This was referenced Jun 23, 2020
Merged
Closed
@WillAyd WillAyd merged commit d000e70 into pandas-dev:master Jun 23, 2020
@WillAyd
Copy link
Member

WillAyd commented Jun 23, 2020

Thanks @alimcmaster1

@alimcmaster1
Copy link
Member Author

Thanks @alimcmaster1

Thanks @WillAyd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Clean Docs
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
8 participants
@alimcmaster1 @wesm @WillAyd @TomAugspurger @jorisvandenbossche @datapythonista @gfyoung @simonjayhawkins