Skip to content

CLN: GH29547 format with f-strings #34914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

CLN: GH29547 format with f-strings #34914

wants to merge 0 commits into from

Conversation

DanBasson
Copy link
Contributor

@DanBasson DanBasson commented Jun 20, 2020 •
edited by jreback
Loading

xref #29547
replace .format() for f-strings in the following:

  • pandas/tests/series/indexing/test_numeric.py

@pep8speaks
Copy link

pep8speaks commented Jun 20, 2020 •
edited
Loading

Hello @DanBasson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-21 17:03:13 UTC

dsaxton
dsaxton reviewed Jun 20, 2020
View reviewed changes
pandas/tests/series/indexing/test_numeric.py Outdated
"cannot do slice indexing on DatetimeIndex with these indexers "
r"\[{key}\] of type float"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the brackets have been removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess so since it gave me a pep error

@DanBasson
Copy link
Contributor Author

hi @jreback,

do you understand the error ?
any help will be appriciated.
CI is successful.

@jreback jreback added the Code Style Code style, linting, code_checks label Jun 23, 2020
@DanBasson DanBasson closed this Jun 24, 2020
@DanBasson DanBasson mentioned this pull request Jun 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsaxton dsaxton dsaxton left review comments

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanBasson @pep8speaks @dsaxton @jreback