Skip to content

BUG: plotting layout patch #34905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Conversation

lyashevska
Copy link
Contributor

This fixes a layout problem.

@jreback
Copy link
Contributor

jreback commented Jun 20, 2020

hmm can you show the before / after. also please add a whatsnew note in plotting / bug fixes / 1.1.

@jreback jreback added the Visualization plotting label Jun 20, 2020
@jreback jreback changed the title ENH:fixed layout BUG: plotting layout patch Jun 20, 2020
@lyashevska
Copy link
Contributor Author

before
after

@jreback jreback added this to the 1.1 milestone Jun 20, 2020
@jreback
Copy link
Contributor

jreback commented Jun 20, 2020

kk great, pls add a whatsnew (e.g. when a user would care about this) and ping on green.

@@ -1006,6 +1006,7 @@ Plotting
- Bug in :meth:`DataFrame.hist` where the order of ``column`` argument was ignored (:issue:`29235`)
- Bug in :meth:`DataFrame.plot.scatter` that when adding multiple plots with different ``cmap``, colorbars alway use the first ``cmap`` (:issue:`33389`)
- Bug in :meth:`DataFrame.plot.scatter` was adding a colorbar to the plot even if the argument `c` was assigned to a column containing color names (:issue:`34316`)
- Bug in :meth:`Series.bootstrap_plot` was cluttered axes and overlapping labels (:issue:`34905`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this reference doesn't exist, i think you need pandas.plotting.bootstrap_plot, ping when green.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be solved now, could you please have a look?

@jreback jreback merged commit 526f404 into pandas-dev:master Jun 23, 2020
@jreback
Copy link
Contributor

jreback commented Jun 23, 2020

thanks @lyashevska

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants