TST:add test for df replace GH34871 #34904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test now does not check for actual equality between original and new dataframe anymore, this behavior needs treduce test to only fail for exception test now does not check for actual equality between original and new dataframe anymore, this behavior needs to be addressed in another bug fix be addressed in another bug fix
3 tasks
jreback
requested changes
Jun 20, 2020
jreback
added
Period
don't reference old version assert expected result
jreback
requested changes
Jun 23, 2020
|
|
||
| df_expected_result = pd.DataFrame({"Per": [pd.Period("2020-01")] * 3}) | ||
| # currently replace() changes dtype from Period to object | ||
| df_expected_result["Per"] = df_expected_result["Per"].astype(object) |
There was a problem hiding this comment.
so this is wrong, we want to xfail this test, this should not change the dtype, pls add the issue number in the xfail itself
There was a problem hiding this comment.
meaning, yes it doesn't raise an expection, but the output is still converted to object
There was a problem hiding this comment.
gotcha, thanks for teaching me about xfail. i changed the test to now expect the result we would like to see from replace() in the future, and to xfail for now.
unit test for replace() now checks whether the dataframe returned is equal to how we want the function to behave, i.e. no changes to either data values or data type. this behavior needs to be implemented in the future, thux xfail-ing for now.
jreback
approved these changes
Jun 24, 2020
samc1213
added a commit
to samc1213/pandas
that referenced
this pull request
Oct 4, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffadd tiny regression test for not failing on calling df.replace() with Period column
working on this revealed other quirks of df.replace(): it now does not raise an exception anymore, and the dataframe returned by replace() has the right values. However, the dtype of a Period column changes to Object, which is surprising.
I've added the observations to GH34871