DOC: add note about the values of unit for pd.to_datetime #34899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jun 20, 2020
doc/source/user_guide/timeseries.rst
Outdated
| @@ -319,6 +319,11 @@ which can be specified. These are computed from the starting point specified by | |||
| pd.to_datetime([1349720105100, 1349720105200, 1349720105300, | |||
| 1349720105400, 1349720105500], unit='ms') | |||
|
|
|||
| .. note:: | |||
|
|
|||
| The strings used to specify a ``unit`` are not the same are those by ``format``. | |||
There was a problem hiding this comment.
I am not really sure what format refers to here, can you clarify
There was a problem hiding this comment.
Sure! I'm talking about the "%Y-%M-%D" -type strings. Is the new commit clearer?
jreback
approved these changes
Jun 20, 2020
|
k looks reasonable |
|
thanks @aidanmontare-edu |
|
No problem!
…On Sat, Jun 20, 2020 at 4:12 PM Jeff Reback ***@***.***> wrote:
thanks @aidanmontare-edu <https://github.com/aidanmontare-edu>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34899 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALMCGOPQ6H33O473MN6JGALRXUJZTANCNFSM4ODMJOLA>
.
--
Sincerely,
Aidan Montare
CWRU Class of 2021
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unitoption forpandas.to_datetimetakes different format strings than theformatoption,which makes sense, but caught me off-guard as a new user. It would be helpful if the documentation
mentioned this.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff