TST: Add test to verify align behaviour on CategoricalIndex #34880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesdong1991
added
the
Testing
jorisvandenbossche
changed the title
align behaviour on CategoricalIndex
|
@jorisvandenbossche anything that still needs to happen here? |
jreback
requested changes
Jun 26, 2020
| @@ -129,6 +129,26 @@ def test_align_mixed_int(self, mixed_int_frame): | |||
| ) | |||
| tm.assert_index_equal(bf.index, Index([])) | |||
|
|
|||
| def test_align_categorical(self): | |||
There was a problem hiding this comment.
can you rename this to test_align_categorical_unordered and then add an ordered version (alt is to parameterize this)
There was a problem hiding this comment.
I guess the same holds as previous, if one categorical is ordered and the other isn't, the expected dtype is object? If not, let me know so I can adjust the test
|
@MBrouns can you merge master & push? Will hopefully fix the CI issue. |
verify that aligning two dataframes with a `CategoricalIndex` does not change the type of the index.
… no shortcut path that skips aligning
TomAugspurger
approved these changes
Jul 6, 2020
jreback
approved these changes
Jul 6, 2020
jreback
added
the
Indexing
|
thanks @MBrouns very nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify that aligning two dataframes with a
CategoricalIndexdoes not change the type of the index.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff