-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG/TST: Read from Public s3 Bucket Without Creds #34877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TomAugspurger
merged 15 commits into
pandas-dev:master
from
alimcmaster1:mcmali-s3-pub-test
Jul 15, 2020
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
eba6c5f
Public Bucket Read Test
alimcmaster1 523480c
Public Bucket Read Test
alimcmaster1 5d63555
Handle Perm Error
alimcmaster1 b7ab45f
Merge remote-tracking branch 'upstream/master' into mcmali-s3-pub-test
alimcmaster1 07394f4
Merge remote-tracking branch 'upstream/master' into mcmali-s3-pub-test
alimcmaster1 e308bf8
Add with Creds Test
alimcmaster1 9b92536
Merge remote-tracking branch 'upstream/master' into mcmali-s3-pub-test
alimcmaster1 5413599
Merge remote-tracking branch 'upstream/master' into mcmali-s3-pub-test
alimcmaster1 49ce4a8
Allows Reads from Public Buckets
alimcmaster1 03ee472
Allows Reads from Public Buckets
alimcmaster1 2c9c755
Allows Reads from Public Buckets
alimcmaster1 bec58bb
Merge remote-tracking branch 'upstream/master' into mcmali-s3-pub-test
alimcmaster1 4d0c980
Update pandas/io/common.py
alimcmaster1 2b3d2a7
Merge remote-tracking branch 'upstream/master' into mcmali-s3-pub-test
alimcmaster1 edf3ed3
Merge branch 'mcmali-s3-pub-test' of https://github.com/alimcmaster1/…
alimcmaster1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alimcmaster1 what happens if we just catch PermissionError? Do you know which cases raise a NoCredentialsError or ClientError?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A
ClientError
was raised bytest_read_without_creds_from_pub_bucket
in this 3.7 build - https://travis-ci.org/github/pandas-dev/pandas/jobs/706462160We were catching
NoCredentialsError
before the fspec change - https://github.com/pandas-dev/pandas/pull/34266/files#diff-a37b395bed03f0404dec864a4529c97dL34 - so I decided to catch to be on the safe side. (But can't see a case that raises)Thoughts?