CI: Fail on warning for 3.9 #34852
CI: Fail on warning for 3.9 #34852
Conversation
.travis.yml
Outdated
| @@ -33,7 +33,7 @@ matrix: | |||
| - dist: bionic | |||
| python: 3.9-dev | |||
| env: | |||
| - JOB="3.9-dev" PATTERN="(not slow and not network and not clipboard)" | |||
| - JOB="3.9-dev" PATTERN="(not slow and not network and not clipboard)" TEST_ARGS="-Werror" | |||
There was a problem hiding this comment.
This gets passed to pytest right? I think the flag there is just -W
There was a problem hiding this comment.
Or could even do in the setup.cfg
There was a problem hiding this comment.
Trying it out in setup.cfg. The primary issue I see is that we don't necessarily want warnings from optional dependencies to cause errors. For now I've limited to just our required dependencies.
|
Just out of curiosity what are you trying to do specific to 3.9? I think great to do this, though obviously would require a good deal of work to get it to work across all builds |
The 3.9 job builds NumPy from source, and so it can be slightly ahead of the numpydev build (our only other build to error on warnings) which uses NumPy's nightly wheels. Agreed this would be nice to have. Just not sure if /when I'll have time to get to work through all of these. There are more failures than I expected :) |
|
I'm not going to get to this any time soon. |
This should fail till #34835 is in.