DOC: move 'Other API changes' under correct section #34817
Conversation
|
This was inspired by looking at #34801, but this PR does not yet "fix" anything, just cleans up the organization. |
|
|
||
| - :meth:`Series.describe` will now show distribution percentiles for ``datetime`` dtypes, statistics ``first`` and ``last`` | ||
| will now be ``min`` and ``max`` to match with numeric dtypes in :meth:`DataFrame.describe` (:issue:`30164`) | ||
| - Added :meth:`DataFrame.value_counts` (:issue:`5377`) |
There was a problem hiding this comment.
why are you lumping enhancements in here? this is very confusing
There was a problem hiding this comment.
Well, this are the entries that were originally (look at the diff above) under "Other API changes".
I fully agree that this is an enhancement, and that should be cleaned-up, see #34801, but here I am just correcting the order of the sections, not actually fixing the bullet points itself as mentioned in the comment above.
There was a problem hiding this comment.
ok fair enough, yeah these should really be separated a more fine grained way
There was a problem hiding this comment.
Yeah, value_counts here should simply be moved to the enhancement section, and we can discuss in #34801 what kind of more fine grained sections we want for the API changes itself.
The "Other API changes" bullet points were split in two (one part under "Other API changes", and one part directly under "Backwards incompatible API changes"), and in previous whatsnew files, the "Other API changes" is also a subsection of "Backwards incompatible API changes".
So moved a few things around to make this consistent.