REF: move Resolution to tslibs.dtypes #34813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At some point in one of the previous PRs, you said that deduplication might not be possible after all (#34587 (comment)). Can you give a bit of context on what your idea / goal is on that now? |
jreback
approved these changes
Jun 16, 2020
| @@ -127,6 +131,7 @@ _attrname_to_abbrevs = { | |||
| "nanosecond": "N", | |||
| } | |||
| cdef dict attrname_to_abbrevs = _attrname_to_abbrevs | |||
| cdef dict _abbrev_to_attrnames = {v: k for k, v in attrname_to_abbrevs.items()} | |||
There was a problem hiding this comment.
should make these both private or public
There was a problem hiding this comment.
the public one is used outside this module, the private one is not
The mapping between FreqGroup and Resolution is not going to be a bijection, but im now thinking that both FreqGroup.FR_DAY and FreqGroup.FR_BUS map to Resolution.RESO_DAY. This will allow us to clean up semi-kludge here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much a clean move, in preparation for making FreqGroup an enum and trying to de-duplicate our 3+ enum-like classes