BUG: apply() fails on some value types #34812
Conversation
|
Thanks @Veronur - can you add a test to show how this fixes the linked issue? |
|
Sure it will be done but i think ill need to look into what made it fail the pandas-dev.pandas and the pandas-dev.pandas (Windows py37_np18) first |
|
I am working on the test right now, i linked this first pull request just to start the conversaion on on whether looking at this table the change makes sense. |
|
Alright so i made the test for the issue and i fail before the change and stops failing after. If there is anything else to be done, please let me know. If not let me know and i will make my last pull request with the test and the change |
|
Rebased the all commits into one so it becomes easier to look into them |
|
Merging master should fix CI. Can you add a release note to whatsnew/v1.1.10.rst? |
Veronur
force-pushed
the
issue-#34529
branch
2 times, most recently
from
59a5a95 to
fb7ad08
Compare
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -1032,6 +1032,7 @@ ExtensionArray | |||
| - Fixed bug where :meth:`StringArray.memory_usage` was not implemented (:issue:`33963`) | |||
| - Fixed bug where :meth:`DataFrameGroupBy` would ignore the ``min_count`` argument for aggregations on nullable boolean dtypes (:issue:`34051`) | |||
| - Fixed bug that `DataFrame(columns=.., dtype='string')` would fail (:issue:`27953`, :issue:`33623`) | |||
| - Fixed regression where :meth:`DataFrame.apply` would raise ``ValueError`` for elements whth ``S`` dtype (:issue:`34529`) | |||
There was a problem hiding this comment.
this doesn't here, put in reshaping section
correction and test for issue-pandas-dev#34529 made the formating changes fixing tests on issue-pandas-dev#34529 add whats new entry on issue-pandas-dev#34539 add whats new entry correction issue-pandas-dev#34539 whats new correction issue-pandas-dev#34539
|
is there anything else that needs to be done here? |
|
thanks @Veronur |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff