-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: reading line-format JSON from file url #27135 #34811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Travis CI check for python3.9-dev failed. Not sure what's going on. |
I think looks good. Can you add a whatsnew note for v1.1? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm @jreback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. if you can add a whatsnew note in 1.1, bug fixes I/O section. ping on green.
0a517f9
to
6cc04ee
Compare
Thanks @VirosaLi |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff