Skip to content

TST: Period with Timestamp overflow #34755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 5, 2020
Merged

TST: Period with Timestamp overflow #34755

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f05de1
#TST #13346 added tests
Jun 13, 2020
3c33ec8
TST #13346 taken review into account
Jun 14, 2020
9765d1d
Merge remote-tracking branch 'upstream/master' into TST_13346
Jul 7, 2020
37f03d6
Added tests for #13346 - with review
Jul 7, 2020
0ed2fdc
Merge remote-tracking branch 'upstream/master' into TST_13346
Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions pandas/tests/scalar/period/test_period.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

from pandas._libs.tslibs import iNaT, period as libperiod
from pandas._libs.tslibs.ccalendar import DAYS, MONTHS
from pandas._libs.tslibs.np_datetime import OutOfBoundsDatetime
from pandas._libs.tslibs.parsing import DateParseError
from pandas._libs.tslibs.period import INVALID_FREQ_ERR_MSG, IncompatibleFrequency
from pandas._libs.tslibs.timezones import dateutil_gettz, maybe_get_tz
Expand Down Expand Up @@ -767,6 +768,40 @@ def test_period_deprecated_freq(self):
assert isinstance(p1, Period)
assert isinstance(p2, Period)

def period_constructor(bound, offset):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just define this in the test since it's only used there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK done

return Period(
year=bound.year,
month=bound.month,
day=bound.day,
hour=bound.hour,
minute=bound.minute,
second=bound.second + offset,
freq="us",
)

@pytest.mark.parametrize("bound, offset", [(Timestamp.min, -1), (Timestamp.max, 1)])
def test_start_time_and_end_time_bounds(self, bound, offset):
# GH #13346
period = TestPeriodProperties.period_constructor(bound, -offset)
assert period.start_time.round(freq="S") == period.to_timestamp().round(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you parameterize over start_time and end_time so you can just call getattr(period, time_variable).method(...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests were splitted in two tests test_outter_bounds_start_and_end_time and test_inner_bounds_start_and_end_time with a better parametrization.
Thanks for the tips, I didn't knew about getattr function.

freq="S"
)
assert period.end_time.round(freq="S") == period.to_timestamp().round(freq="S")

result = period.start_time.floor("S")
expected = (bound - offset * Timedelta(1, unit="S")).floor("S")
assert result == expected

result = period.end_time.floor("S")
expected = (bound - offset * Timedelta(1, unit="S")).floor("S")
assert result == expected

period = TestPeriodProperties.period_constructor(bound, offset)
with pytest.raises(OutOfBoundsDatetime, match="Out of bounds nanosecond"):
period.start_time
with pytest.raises(OutOfBoundsDatetime, match="Out of bounds nanosecond"):
period.end_time

def test_start_time(self):
freq_lst = ["A", "Q", "M", "D", "H", "T", "S"]
xp = datetime(2012, 1, 1)
Expand Down