CLN: make Info and DataFrameInfo subclasses #34743
Conversation
MarcoGorelli
changed the title
| # Column Non-Null Count Dtype | ||
| # Column Non-Null Count Dtype | ||
| --- ------ -------------- ----- | ||
| 0 int_col 5 non-null int64 | ||
| 1 text_col 5 non-null object | ||
| 2 float_col 5 non-null float64 |
There was a problem hiding this comment.
I'd accidentally introduced these extra whitespaces when I indented the docstrings as part of a previous PR, and so am fixing them now
| memory_usage: Optional[Union[bool, str]] = None, | ||
| null_counts: Optional[bool] = None, | ||
| ): | ||
| if buf is None: # pragma: no cover |
There was a problem hiding this comment.
why do you need the pragma here?
There was a problem hiding this comment.
Noticed this is in the current implementation. Not sure of reasoning but yea probably safe to remove
There was a problem hiding this comment.
Yes, it was from the current implementation - have removed
pandas/io/formats/info.py
Outdated
| show_counts = self.null_counts | ||
| exceeds_info_cols = col_count > max_cols | ||
|
|
||
| def _sizeof_fmt(num, size_qualifier): |
There was a problem hiding this comment.
move this to a module level function
pandas/io/formats/info.py
Outdated
| for system-level memory consumption, and include it in the returned | ||
| values. | ||
|
|
||
| Returns |
There was a problem hiding this comment.
you can put all of the doc-strings on the base class
|
looks good can you merge master and ping on green. |
Thanks @jreback - green now |
|
Friendly ping 😄 (sorry to do this, but I can submit a PR for |
|
thanks @MarcoGorelli very nice |
precursor to #31796
Makes Info class and DataFrameInfo subclass so there's no need for all the