Skip to content

BUG: Fixed Series.replace for EA with casting #34733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 15, 2020
Merged

BUG: Fixed Series.replace for EA with casting #34733

merged 6 commits into from
Jun 15, 2020

Conversation

TomAugspurger
Copy link
Contributor

Closes #34530

@TomAugspurger TomAugspurger added the replace replace method label Jun 12, 2020
@TomAugspurger TomAugspurger added this to the 1.1 milestone Jun 12, 2020
@simonjayhawkins
Copy link
Member

@TomAugspurger

in the OP

The code does not work on Pandas Version 1.0.4. It throws an exception. However, it works on Pandas Version 1.0.1, and also with dtype="int64.

is this PR a candidate for backport?

@TomAugspurger
Copy link
Contributor Author

Yeah, I suppose so. Let me update the whatsnew.

@TomAugspurger TomAugspurger modified the milestones: 1.1, 1.0.5 Jun 15, 2020
@TomAugspurger
Copy link
Contributor Author

OK should be ready once CI passes @simonjayhawkins. I've added to the 1.0.5 milestone.

@jreback jreback added the ExtensionArray Extending pandas with custom dtypes or arrays. label Jun 15, 2020
@jreback jreback merged commit 18f9460 into pandas-dev:master Jun 15, 2020
@jreback
Copy link
Contributor

jreback commented Jun 15, 2020

thanks @TomAugspurger

@simonjayhawkins
Copy link
Member

@meeseeksdev backport to 1.0.x

@pandas-dev pandas-dev deleted a comment from lumberbot-app bot Jun 16, 2020
simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Jun 16, 2020
@TomAugspurger @simonjayhawkins
Backport PR pandas-dev#34733 on branch 1.0.x (BUG: Fixed Series.repla…
ec325a6 
…ce for EA with casting)
@simonjayhawkins simonjayhawkins mentioned this pull request Jun 16, 2020
Merged
simonjayhawkins added a commit that referenced this pull request Jun 16, 2020
@simonjayhawkins @TomAugspurger
Backport PR #34733 on branch 1.0.x (BUG: Fixed Series.replace for EA …
860d5fd 
…with casting) (#34819)

Co-authored-by: Tom Augspurger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. replace replace method
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.

BUG: series with dtype "Int64" don't work correctly with replace() method
3 participants
@TomAugspurger @simonjayhawkins @jreback