Skip to content

ENH: Bring Series.dot up to par with DataFrame.dot #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2013

Conversation

dieterv77
Copy link
Contributor

If second argument is Series or DataFrame, ensures alignment of indices.
If second argument is some type of ndarray, just fall back to np.dot on the values.
This mirrors the behavior in DataFrame.dot

Includes unittest

@ghost
Copy link

ghost commented Apr 27, 2013

@dieterv77 , by chance, I updated CONTRIBUTING.md today with instructions
on getting Travis-CI working, can you try it out and let me know if it works out for you?

@dieterv77
Copy link
Contributor Author

@y-p I actually already configured it after i saw your instructions that you committed today. I pushed an old local branch to my fork and it triggered a build on travis. Any way that i can get it to trigger on this PR?

thanks

@ghost
Copy link

ghost commented Apr 27, 2013

I have these aliases defined in .bashrc:

alias gca='git commit --amend'
alias gcac='gca -C HEAD'

so doing gcac gives the current branch a new hash without touching anything else.
if you then force push that to the PR branch, it should trigger a new build on travis for this PR.

@dieterv77
Copy link
Contributor Author

Looks like that worked. thanks

dieterv77 added a commit that referenced this pull request Apr 29, 2013
ENH: Bring Series.dot up to par with DataFrame.dot
@dieterv77 dieterv77 merged commit 77618f0 into pandas-dev:master Apr 29, 2013
@ghost
Copy link

ghost commented May 20, 2013

I just hit this and fixed with 66cbdc0.
fyi @dieterv77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants