Skip to content

DOC: updated plotting/_misc.py for PR08 errors #34652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

willpeppo
Copy link
Contributor

No description provided.

@alimcmaster1
Copy link
Member

Thanks for the PR - mind referring the issue on this?

@willpeppo
Copy link
Contributor Author

yes no problem at a all... what's the best way to do that? Just put the issue number in the comments ? Thanks in advance for the guidance.

@jreback jreback added this to the 1.1 milestone Jun 8, 2020
@alimcmaster1
Copy link
Member

Exactly - the template should help. #25232

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this conflicts a bit with PRs like #32439 that try to make the word pandas always lowercase. With that in mind I would say just remove the word pandas here, as it doesn't add any value

@WillAyd WillAyd merged commit d584cc1 into pandas-dev:master Jun 9, 2020
@WillAyd
Copy link
Member

WillAyd commented Jun 9, 2020

Great thanks @willpeppo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants