BUG/API: Disallow unit if input to Timedelta and to_timedelta is/contains str #34634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for the behavior? This is typically the first thing we look for in any PR |
WillAyd
added
Datetime
6 tasks
|
this is a replacement for #34379? |
|
@jreback Fixed. Thanks! |
jreback
requested changes
Jun 8, 2020
pandas/_libs/tslibs/timedeltas.pyx
Outdated
|
|
||
| # Usually, we have all strings. If so, we hit the fast path. | ||
| # If this path fails, we try conversion a different way, and | ||
| # this is where all of the error handling will take place. | ||
| try: | ||
| for i in range(n): | ||
| if isinstance(values[i], str): |
There was a problem hiding this comment.
this should be in the clause on L251
jreback
approved these changes
Jun 8, 2020
|
thanks @pdnm very nice patch! keep em coming! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff