Revert backport of #33632: Parquet & s3 I/O changes #34632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimcmaster1
commented
Jun 7, 2020
pandas/tests/io/test_parquet.py
Outdated
| @@ -489,37 +485,15 @@ def test_categorical(self, pa): | |||
| expected = df.astype(object) | |||
| check_round_trip(df, pa, expected=expected) | |||
|
|
|||
| # GH#33077 2020-03-27 | |||
| @pytest.mark.xfail( | |||
| locale.getlocale()[0] == "zh_CN", | |||
There was a problem hiding this comment.
``dom, 07 giu 2020 15:58:39 GMT``` https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=36889&view=logs&j=98c84d08-34d8-513e-80be-2c581992dd5a&t=f75024c1-aff0-57fb-4f0e-35923b654e09
Seems to also fail now for it_IT locale ?
There was a problem hiding this comment.
test_s3_roundtrip failures were why the PRs were backported as this issue (with it_IT) was not been seen on master. see OP in #34173 (comment) (logs no longer available)
I think you can just skip this, see #34173 (comment)
There was a problem hiding this comment.
Thanks done - looks like the Doc build is failing which I think is unrelated.
jreback
changed the title
Also skip for it_IT locale
|
The doc failure is related to #34458, which needs to be backported |
jorisvandenbossche
approved these changes
Jun 9, 2020
This was referenced Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #34626 (comment)
Revert backport of #33632
Backport: #34173
cc @jorisvandenbossche @simonjayhawkins