-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TYP: some type annotations for interpolate #34631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
WillAyd
merged 9 commits into
pandas-dev:master
from
simonjayhawkins:series-interpolate-types
Jun 7, 2020
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f10d969
WIP: avoid internals for Series.interpolate
simonjayhawkins c42e965
deduplicate and typing
simonjayhawkins 9df9e7e
docstring
simonjayhawkins 5847946
Merge remote-tracking branch 'upstream/master' into series-interpolate
simonjayhawkins b88bc74
pass index to _interpolate
simonjayhawkins f99f3a7
revert to keep just the typing
simonjayhawkins 3feaef3
fix clean_interp_method
simonjayhawkins fc4f619
black fixup
simonjayhawkins 0f60171
revert addition of order to clean_interp_method signature
simonjayhawkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are kwargs even required here any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would imagine so, split out order so that can add type annotation for internal checks. will double check though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't appear that we pass the kwargs through to np.interp (left, right and period) but do for scipy.interpolate.UnivariateSpline
did you mean kwargs not used in this function? That's true, but would need to do
order = kwargs.get("order")
in the calling functions if I remove kwargs here. I don't see that as an improvement.should I revert this change?