TST: boolean indexing using .iloc #20627 #34622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jun 7, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
WillAyd
reviewed
Jun 7, 2020
jreback
requested changes
Jun 8, 2020
| def test_iloc_with_boolean_operation(): | ||
| # GH 20627 | ||
| result = DataFrame([[0, 1], [2, 3], [4, 5], [6, np.nan]]) | ||
| result.iloc[result.index <= 2] *= 2 |
There was a problem hiding this comment.
you need to copy result each time you are using it
There was a problem hiding this comment.
Are you sure ? result is modified inplace ? (or I don't understand)
There was a problem hiding this comment.
i get it. for each part of the test you want to reconstruct result, so that the in place mods only affect 1 part and are not consecutive.
jreback
changed the title
jreback
added
the
Indexing
jreback
approved these changes
Jun 9, 2020
jreback
requested changes
Jun 9, 2020
|
I think everything is done. The last PR is green. |
mroeschke
approved these changes
Jun 13, 2020
|
Thanks @OlivierLuG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffA simple test was added to close this issue.