BUG: Pandas changes dtypes of columns when no float (or other) assignments are done to this column #34573 #34599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments are done to this column pandas-dev#34573
simonjayhawkins
added
Bug
Dtype Conversions
…ict-changing-dtypes
jreback
requested changes
Jun 8, 2020
pandas/core/indexing.py
Outdated
| @@ -1844,7 +1844,8 @@ def _setitem_with_indexer_missing(self, indexer, value): | |||
| if len(value) != len(self.obj.columns): | |||
| raise ValueError("cannot set a row with mismatched columns") | |||
|
|
|||
| value = Series(value, index=self.obj.columns, name=indexer) | |||
| dtype = object if isinstance(value, dict) else None | |||
There was a problem hiding this comment.
i would integrate this with the if clause above
There was a problem hiding this comment.
or rather the if/else on L1840
jreback
approved these changes
Jun 9, 2020
|
thanks @simonjayhawkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff