Skip to content

Improve document for **kwargs argument of pandas.DataFrame.to_markdown #34594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Improve document for **kwargs argument of pandas.DataFrame.to_markdown #34594

merged 1 commit into from
Jun 7, 2020

Conversation

nuka137
Copy link
Contributor

@nuka137 nuka137 commented Jun 5, 2020

@nuka137 nuka137 changed the title Improve document of **kwargs argument of pandas.DataFrame.to_markdown Improve document for **kwargs argument of pandas.DataFrame.to_markdown Jun 5, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WillAyd
Copy link
Member

WillAyd commented Jun 7, 2020

Sorry thought Tom implemented the to_markdown but looks like it was @MarcoGorelli - does this look good to you?

@MarcoGorelli
Copy link
Member

Sorry thought Tom implemented the to_markdown but looks like it was @MarcoGorelli

Well, it was me but with the core team holding my hand through the process :)

does this look good to you?

LGTM, tried building it and the link works as expected

@WillAyd WillAyd merged commit 4d44909 into pandas-dev:master Jun 7, 2020
@WillAyd
Copy link
Member

WillAyd commented Jun 7, 2020

Great thanks @nuka137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: The argument of pandas.DataFrame.to_markdown is unfriendly
3 participants