REF: implement c_FreqGroup, FreqGroup in tslibs.dtypes #34588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Jun 7, 2020
| @@ -106,3 +106,20 @@ _period_code_map.update({ | |||
| "W": 4000, # Weekly | |||
| "C": 5000, # Custom Business Day | |||
| }) | |||
|
|
|||
|
|
|||
| class FreqGroup: | |||
There was a problem hiding this comment.
Maybe overlooking something simple but do we need both or does the enum alone suffice?
There was a problem hiding this comment.
the one in the .pxd we can't access from python-space
There was a problem hiding this comment.
also i expect before long we'll make this one into class FreqGroup(Enum) to de-duplicate it with Resolution
WillAyd
approved these changes
Jun 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are already used in libperiod, better to be explicit about it.
Coming up: make FreqGroup into an enum with helper methods to convert between FreqGroup/PeriodDtype/DateOffset/Resolution