-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: DataFrame.reindex improve summary and return type #34584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
gauravchandok
wants to merge
6
commits into
pandas-dev:master
from
gauravchandok:DataFrame_reindex_33888
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
01d9bd2
Change in DataFrame.reindex doc summary and result
gauravchandok d1daba4
DataFrame reindex summary/return: 2nd attempt
gauravchandok b15b121
DataFrame reindex Summary/return: 3
gauravchandok 68cad27
DataFrame reindex Summary/return: 4
gauravchandok ba7a18a
DataFrame reindex Summary/return: 5
gauravchandok de99347
DataFrame reindex Summary/return: 6
gauravchandok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4241,9 +4241,9 @@ def reindex(self: FrameOrSeries, *args, **kwargs) -> FrameOrSeries: | |
""" | ||
Conform %(klass)s to new index with optional filling logic. | ||
|
||
Places NA/NaN in locations having no value in the previous index. A new object | ||
is produced unless the new index is equivalent to the current one and | ||
``copy=False``. | ||
Places NA/NaN in locations having no value in the previous index. A new | ||
DataFrame with an additional index is generated subject to customization | ||
gauravchandok marked this conversation as resolved.
Show resolved
Hide resolved
|
||
with parameters. | ||
|
||
Parameters | ||
---------- | ||
|
@@ -4286,7 +4286,7 @@ def reindex(self: FrameOrSeries, *args, **kwargs) -> FrameOrSeries: | |
|
||
Returns | ||
------- | ||
%(klass)s with changed index. | ||
%(klass)s with 2 indices. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is not correct, only 1 index is changed.
gauravchandok marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
See Also | ||
-------- | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is generic, so could be Series/DataFrame