Skip to content

TST: series offset artithmetic tests #34582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

TST: series offset artithmetic tests #34582

wants to merge 9 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 4, 2020

…racting a series of DateOffsets to / from a series of Timestamps (test_series_add_daytime_offset, test_series_add_daytime_offset)

KD-dev-lab added 2 commits June 4, 2020 23:49
TST: Added tests to check the arithmetic behaviour of adding and subt…
28ae2ae 
…racting a series of DateOffsets to / from a series of Timestamps (test_series_add_daytime_offset, test_series_add_daytime_offset)
TST: Run isort for test_arithmetic.py
b9b04e6
@ghost ghost closed this Jun 5, 2020
@ghost ghost reopened this Jun 5, 2020
dsaxton
dsaxton reviewed Jun 6, 2020
View reviewed changes
Copy link
Member

@dsaxton dsaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May also be worth adding tests for the Index cases mentioned in the issue if they don't exist already

@dsaxton dsaxton added Numeric Operations Arithmetic, Comparison, and Logical operations Testing pandas testing functions or related to the test suite Datetime Datetime data dtype labels Jun 6, 2020
TST: Reworked tests for GH#19211 after review and added several tests…
5f8aaed 
… considering Index and DaytimeIndex. Included pd.offsets.MonthEnd() and pd.offsets.MonthStart() in offset Series.
@ghost ghost requested a review from dsaxton June 6, 2020 10:07
@ghost ghost requested a review from dsaxton June 7, 2020 18:23
@ghost
Copy link
Author

ghost commented Jun 9, 2020

@dsaxton / @jbrockmendel
Any further comments?

@ghost ghost changed the title TST: Added tests to check the arithmetic behaviour of adding and subt… TST: Modified tests to cover GH#19211 Jun 10, 2020
@ghost ghost requested a review from jbrockmendel June 10, 2020 00:50
@ghost ghost marked this pull request as draft June 10, 2020 00:59
@jbrockmendel
Copy link
Member

I'm stepping away for a little while, maybe @jorisvandenbossche or @TomAugspurger can take a look.

@TomAugspurger
Copy link
Contributor

On master I see a PerformancWarning with the original example. We'll need to make sure that doesn't leak through in the tests.

@jreback jreback added this to the 1.1 milestone Jun 14, 2020
@jreback
Copy link
Contributor

jreback commented Jun 14, 2020

is this still a draft? and can you address @TomAugspurger comment, e.g. we may want to see where the PerformanceWarning are coming from

@jreback jreback changed the title TST: Modified tests to cover GH#19211 TST: series offset artithmetic tests Jun 14, 2020
@jreback jreback removed this from the 1.1 milestone Jul 9, 2020
@jreback
Copy link
Contributor

jreback commented Jul 17, 2020

can u merge master and update

@simonjayhawkins
Copy link
Member

closing as user is ghost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsaxton dsaxton Awaiting requested review from dsaxton

@jbrockmendel jbrockmendel Awaiting requested review from jbrockmendel

Assignees
No one assigned
Labels
Datetime Datetime data dtype Numeric Operations Arithmetic, Comparison, and Logical operations Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Series[offsets] + Series[datetime64] fails
5 participants
@jbrockmendel @TomAugspurger @jreback @simonjayhawkins @dsaxton