Skip to content

solves ci issues with #34575 #34579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

hasnain2808
Copy link
Contributor

Current right output

· Discovering benchmarks
· Running 1 total benchmarks (1 commits * 1 environments * 1 benchmarks)
[  0.00%] ·· Benchmarking existing-py_home_moha_venv_pandas-dev_bin_python
[ 50.00%] ··· arithmetic.ApplyIndex.time_apply_indexgit                                                                                                ok
[ 50.00%] ··· =================================== ==========
                             offset                         
              ----------------------------------- ----------
                      <YearEnd: month=12>          2.05±0ms 
                      <YearBegin: month=1>         1.56±0ms 
                 <QuarterEnd: startingMonth=3>     4.41±0ms 
                <QuarterBegin: startingMonth=3>    2.50±0ms 
                           <MonthEnd>              4.32±0ms 
                          <MonthBegin>             2.31±0ms 
                 <DateOffset: days=2, months=2>    5.67±0ms 
                         <BusinessDay>             10.4±0ms 
                <SemiMonthEnd: day_of_month=15>    14.5±0ms 
               <SemiMonthBegin: day_of_month=15>   14.2±0ms 
              =================================== ==========

@@ -466,7 +466,7 @@ def setup(self, offset):
self.rng = rng

def time_apply_index(self, offset):
offset.apply_index(self.rng)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrockmendel I guess BaseOffset is not used by the non-tick offsets.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we don't have any tests for this public-ish method

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should just privatize

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for apply

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree we should, but need to deprecate unfortunately......an you open an issue?

@jreback jreback added CI Continuous Integration Frequency DateOffsets labels Jun 4, 2020
@jreback jreback added this to the 1.1 milestone Jun 4, 2020
@jreback
Copy link
Contributor

jreback commented Jun 4, 2020

thanks @hasnain2808 ping on green; we can merge this to patch short term.

@hasnain2808
Copy link
Contributor Author

ping

@jreback jreback merged commit 240b8fe into pandas-dev:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Frequency DateOffsets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is failing due to benchmark failing at arithmetic.ApplyIndex.time_apply_index (0.65%)
3 participants