-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
solves ci issues with #34575 #34579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solves ci issues with #34575 #34579
Conversation
@@ -466,7 +466,7 @@ def setup(self, offset): | |||
self.rng = rng | |||
|
|||
def time_apply_index(self, offset): | |||
offset.apply_index(self.rng) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbrockmendel I guess BaseOffset is not used by the non-tick offsets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and we don't have any tests for this public-ish method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should just privatize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for apply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree we should, but need to deprecate unfortunately......an you open an issue?
thanks @hasnain2808 ping on green; we can merge this to patch short term. |
ping |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
solved issues with benchmarks
benchmarks running fine now
Current right output