TST: Added test to check that the freqstr attribute of the index is p… #34572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reserved after a shift operation. Run black and flake8.
dsaxton
reviewed
Jun 4, 2020
| @pytest.mark.parametrize("periods", [1, 2, 3, 4]) | ||
| def test_shift_preserve_freqstr(self, periods): | ||
| # GH#21275 | ||
| data = list(range(0, periods)) |
There was a problem hiding this comment.
You can pass a range directly to the DataFrame constructor so could just be range(periods)
| ) | ||
| assert str(np.dtype(result)) == "int64" | ||
| assert result.index.freqstr == "H" | ||
| tm.assert_series_equal(result, expected) |
There was a problem hiding this comment.
I think assert_series_equal should be enough here since it'll check the index frequencies and dtypes
dsaxton
added
Testing
ghost
requested a review
from 
|
thanks @KD-dev-lab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…reserved after a shift operation. Run black and flake8.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff