Skip to content

Export InvalidIndexError #34570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 14, 2020
Merged

Export InvalidIndexError #34570

merged 5 commits into from
Jun 14, 2020

Conversation

horta
Copy link
Contributor

@horta horta commented Jun 4, 2020

  • closes #xxxx (there is no such an issue)
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jorisvandenbossche
Copy link
Member

@horta there is a pandas.errors submodule where this could be put instead of at the top-level namespace

jreback
jreback requested changes Jun 4, 2020
View reviewed changes
@jreback jreback added the Error Reporting Incorrect or improved errors from pandas label Jun 4, 2020
@horta
Copy link
Contributor Author

horta commented Jun 5, 2020

I have now defined InvalidIndexError at pandas.errors module. Documented it (suggestions?). Most of the diff concerns importing InvalidIndexError from pandas.errors.

@mroeschke
Copy link
Member

Could you include this error in the API reference? https://pandas.pydata.org/docs/reference/general_utility_functions.html#exceptions-and-warnings

jreback
jreback requested changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, ping on green.

@jreback jreback added this to the 1.1 milestone Jun 8, 2020
jreback
jreback requested changes Jun 9, 2020
View reviewed changes
@jreback
Copy link
Contributor

jreback commented Jun 14, 2020

@horta looks fine, can you rebase and update to the comments above, ping on green.

@horta
Copy link
Contributor Author

horta commented Jun 14, 2020

Could you include this error in the API reference? https://pandas.pydata.org/docs/reference/general_utility_functions.html#exceptions-and-warnings

Done.

@jreback
Copy link
Contributor

jreback commented Jun 14, 2020

lgtm ping on green.

@jreback jreback merged commit 07cef29 into pandas-dev:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@horta @jorisvandenbossche @mroeschke @jreback