Skip to content

DOC: Fixed PR06 (wrong parameter type) in pandas.Timestamp #34561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

willpeppo
Copy link
Contributor

No description provided.

@dsaxton
Copy link
Member

dsaxton commented Jun 4, 2020

@willpeppo Your change looks right, but I think you also need to make the corresponding change in pandas/_libs/tslibs/nattype.pyx to get CI to pass

@dsaxton dsaxton added the Docs label Jun 4, 2020
@willpeppo
Copy link
Contributor Author

Dan- thank you for the feedback! I decided over the weekend to make my first oss contribution and have been wrestling through it the past few days. I really appreciate the comment. How did you determine that btw ?

@dsaxton
Copy link
Member

dsaxton commented Jun 4, 2020

Dan- thank you for the feedback! I decided over the weekend to make my first oss contribution and have been wrestling through it the past few days. I really appreciate the comment. How did you determine that btw ?

No problem, thanks for the contribution. You can see what's wrong by clicking the "Details" next to one of the failed pipelines, for example: https://github.com/pandas-dev/pandas/pull/34561/checks?check_run_id=736430284.

It shows that two tests failed and you can take a look at the logs by clicking "View more details on Azure Pipelines" and going to "Tests". There you can look for an error message and by thinking through what's being tested figure out how to fix the issue.

@jorisvandenbossche jorisvandenbossche added this to the 1.1 milestone Jun 4, 2020
@jorisvandenbossche
Copy link
Member

Thanks @willpeppo for the contribution, and @dsaxton for the review!

@jorisvandenbossche jorisvandenbossche merged commit 7388ee5 into pandas-dev:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants