REF: use standard pattern in normalize_i8_timestamps #34507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Jun 1, 2020
|
This one seems to have caused a significant performance regression: https://pandas.pydata.org/speed/pandas/#timeseries.DatetimeAccessor.time_dt_accessor_normalize?p-t='UTC'&commits=4fcc6a66 Is that expected / accepted? |
jreback
reviewed
Jun 9, 2020
| @@ -1036,14 +1035,7 @@ def normalize(self): | |||
| '2014-08-01 00:00:00+05:30'], | |||
| dtype='datetime64[ns, Asia/Calcutta]', freq=None) | |||
| """ | |||
| if self.tz is None or timezones.is_utc(self.tz): | |||
There was a problem hiding this comment.
this fastpath looks like it was removed in favor of the loop in normalize_i8_timestamps. cc @jbrockmendel
|
yah, i was surprised to see that the cython version is non-trivially slower than the numpy version. i have one long-shot guess at a way to speed up the cython version, will try that out today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From here the plan is to move to passing
int64_t*which will allow us to share code between the scalar/vector versions of this function